jerqi commented on code in PR #176:
URL: https://github.com/apache/incubator-uniffle/pull/176#discussion_r951234031
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -284,6 +284,18 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(0L)
.withDescription("For localstorage, it will exit when the failed
initialized local storage exceed the number");
+ public static final ConfigOption<Boolean> BUFFER_FLUSH_ENABLED =
ConfigOptions
+ .key("rss.server.buffer.flush.enabled")
Review Comment:
Could we change the name from `rss.server.buffer.flush.enabled` to
`rss.server.single.buffer.flush.enabled`?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -284,6 +284,18 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(0L)
.withDescription("For localstorage, it will exit when the failed
initialized local storage exceed the number");
+ public static final ConfigOption<Boolean> BUFFER_FLUSH_ENABLED =
ConfigOptions
+ .key("rss.server.buffer.flush.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether buffer flush when size exceeded
rss.server.buffer.flush.threshold");
+
+ public static final ConfigOption<Long> BUFFER_FLUSH_THRESHOLD = ConfigOptions
Review Comment:
Could we change the name from `rss.server.buffer.flush.threshold` to
`rss.server.single.buffer.flush.threshold`?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -284,6 +284,18 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(0L)
.withDescription("For localstorage, it will exit when the failed
initialized local storage exceed the number");
+ public static final ConfigOption<Boolean> BUFFER_FLUSH_ENABLED =
ConfigOptions
+ .key("rss.server.buffer.flush.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether buffer flush when size exceeded
rss.server.buffer.flush.threshold");
+
+ public static final ConfigOption<Long> BUFFER_FLUSH_THRESHOLD = ConfigOptions
+ .key("rss.server.buffer.flush.threshold")
+ .longType()
+ .defaultValue(32 * 1024 * 1024L)
Review Comment:
Could the default value be consistent with
`rss.server.flush.cold.storage.threshold.size`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
