jerqi commented on PR #176: URL: https://github.com/apache/incubator-uniffle/pull/176#issuecomment-1222309788
> I think we should change `this.bufferFlushEnabled && buffer.getSize() >= this.bufferFlushThreshold` to `this.bufferFlushEnabled && buffer.getSize() > this.bufferFlushThreshold` , which should be consistent with `event.getSize() > flushColdStorageThresholdSize` @jerqi It's ok and you can raise a follow-up pr. You'd better add some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
