[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #216: [TEST] Improve SimpleClusterManagerTest

[GitBox]

kaijchen opened a new pull request, #216:
URL: https://github.com/apache/incubator-uniffle/pull/216

   ### What changes were proposed in this pull request?
   
   1. Use `Awaitility.await` to replace arbitrary sleep in tests.
   2. Make `heartbeatTimeoutTest` more deterministic.
   
   ### Why are the changes needed?
   
   To make tests correct and fast.
   And serve as an example of waiting longer for correctness without worrying 
about the speed.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Before
   <img width="609" alt="20 sec" 
src="https://user-images.githubusercontent.com/5821159/189841692-c45ae11b-1c06-475c-859d-821573a8c276.png";>
   
   After
   <img width="611" alt="13 sec" 
src="https://user-images.githubusercontent.com/5821159/189841796-fec3a837-b236-4d7d-b029-0e46a8bcef3c.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For additional commands, e-mail: issues-h...@uniffle.apache.org