jerqi commented on code in PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#discussion_r1124001922


##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -73,7 +73,8 @@ public boolean checkIsHealthy() {
     int corruptedDirs = 0;
 
     for (StorageInfo storageInfo : storageInfos) {
-      if (!storageInfo.checkStorageReadAndWrite()) {
+      if (storageInfo.checkIsSpaceEnough()

Review Comment:
   `checkIsSpaceEnough` can't guaratee that the disk is full. It only means 
that the disk capacity is very high.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to