xianjingfeng commented on code in PR #680:
URL: https://github.com/apache/incubator-uniffle/pull/680#discussion_r1125587631
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/strategy/storage/AppBalanceSelectStorageStrategy.java:
##########
@@ -132,4 +76,9 @@ public synchronized RemoteStorageInfo pickStorage(String
appId) {
LOG.warn("No remote storage is available, we will default to the first.");
return availableRemoteStorageInfo.values().iterator().next();
}
+
+ @Override
+ public Comparator<Map.Entry<String, RankValue>> getComparator() {
+ return (o1, o2) -> 0;
Review Comment:
I think return null is better, We don't need to sort the paths in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
