advancedxy commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130391369
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper.readTree(content);
assertEquals(2, actualObj.size());
- assertEquals(10, actualObj.get("metrics").size());
+ int actualMetrics = 0;
+ for (JsonNode metrics : actualObj.get("metrics")) {
+ if
(CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {
Review Comment:
I'm not sure about this change.
The better way is to call
`org.apache.uniffle.coordinator.metric.CoordinatorMetrics#clear` in
`@beforeAll` of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
