leixm commented on PR #688: URL: https://github.com/apache/incubator-uniffle/pull/688#issuecomment-1465597864
> Could we split this into 4 - 5 parts? > > 1. A streamServer > 2. Netty Utils > 3. Encoder and Decoder > 4. ShuffleNettyGrpcClient > 5. Server's concrete service > 6. Off heap Memory Manager Does point 5 mean that all interfaces are implemented in ShuffleServer? There are already other PRs for point 6, and this has been separated out when it was split before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
