advancedxy commented on code in PR #693:
URL: https://github.com/apache/incubator-uniffle/pull/693#discussion_r1150140939


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssFeatureMatrix.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.shuffle;
+
+public class RssFeatureMatrix {

Review Comment:
   It's not a concept of linear algebra. 
   
   Quote from the ChatGPT's answer, part of it is as following:
   > A feature matrix is a table or grid that presents the features or 
attributes of a product/service in comparison to other products/services in the 
same category. It is used to compare the different versions or variations of a 
product/service across a set of predefined criteria or features.
   
   So the RssFeatureMatrix defines different function/features against 
different spark versions.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to