LuciferYang commented on code in PR #2397:
URL: https://github.com/apache/uniffle/pull/2397#discussion_r1998074782
##########
integration-test/spark-common/src/test/java/org/apache/uniffle/test/RSSStageResubmitTest.java:
##########
@@ -27,34 +28,34 @@
import org.apache.spark.sql.SparkSession;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
import org.apache.uniffle.client.util.RssClientConfig;
import org.apache.uniffle.common.rpc.ServerType;
import org.apache.uniffle.coordinator.CoordinatorConf;
import org.apache.uniffle.server.MockedGrpcServer;
import org.apache.uniffle.server.ShuffleServer;
-import org.apache.uniffle.server.ShuffleServerConf;
import org.apache.uniffle.storage.util.StorageType;
public class RSSStageResubmitTest extends SparkTaskFailureIntegrationTestBase {
@BeforeAll
- public static void setupServers() throws Exception {
- final CoordinatorConf coordinatorConf = getCoordinatorConf();
+ public static void setupServers(@TempDir File tmpDir) throws Exception {
+ final CoordinatorConf coordinatorConf = coordinatorConfWithoutPort();
Map<String, String> dynamicConf = Maps.newHashMap();
dynamicConf.put(CoordinatorConf.COORDINATOR_REMOTE_STORAGE_PATH.key(),
HDFS_URI + "rss/test");
dynamicConf.put(RssSparkConfig.RSS_STORAGE_TYPE.key(),
StorageType.MEMORY_LOCALFILE.name());
dynamicConf.put(
RssSparkConfig.SPARK_RSS_CONFIG_PREFIX +
RssClientConfig.RSS_RESUBMIT_STAGE, "true");
dynamicConf.put(RssSparkConfig.RSS_STORAGE_TYPE.key(),
StorageType.MEMORY_LOCALFILE.name());
addDynamicConf(coordinatorConf, dynamicConf);
- createCoordinatorServer(coordinatorConf);
- ShuffleServerConf grpcShuffleServerConf =
getShuffleServerConf(ServerType.GRPC);
- createMockedShuffleServer(grpcShuffleServerConf);
+ storeCoordinatorConf(coordinatorConf);
Review Comment:
```
storeCoordinatorConf
storeMockShuffleServerConf
storeMockShuffleServerConf
startServersWithRandomPorts
```
looks ok, but is the code above a pattern? Should there be a method defined
like `startServersWithRandomPorts` with type parameters `CoordinatorConf` and
`List<ShuffleServerConf>`? This pattern seems to have some repetition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
