jerqi commented on code in PR #2509:
URL: https://github.com/apache/uniffle/pull/2509#discussion_r2156982271


##########
proto/src/main/proto/Rss.proto:
##########
@@ -636,6 +638,8 @@ message ReportShuffleReadMetricRequest {
   int32 stageId = 2;
   int64 taskId = 3;
   map<string, ShuffleReadMetric> metrics = 4;
+  bool isShuffleReadFailed = 5;

Review Comment:
   Could you remove `shuffle` from the variable name? Because the message 
already has the shuffle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to