zuston commented on issue #2544: URL: https://github.com/apache/uniffle/issues/2544#issuecomment-3075638737
> Moreover, I did a quick investigation on the code and have one theory, seems like a unsafe publication issue, One thread created a codec to compress data with compression statistics and it starts to record in `compressCosts`, but since this code is not thread safe, for some reason thread B enters to action, hitting the statistics method and skipping `isEmpty()` validation because maybe the object is partially there, but it fails on Sort. My idea maybe is to convet the `CompressCost `into a concurrent data structure, or making methods synchronize, just let me know to apply change in a PR Sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
