jerqi commented on code in PR #2620:
URL: https://github.com/apache/uniffle/pull/2620#discussion_r2357419120
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java:
##########
@@ -1148,15 +1148,24 @@ public MutableShuffleHandleInfo
reassignOnBlockSendFailure(
System.currentTimeMillis() - startTime,
partitionSplit,
reassignResult);
- if (partitionSplit) {
- this.reassignTriggeredOnPartitionSplit.set(true);
- } else {
- this.reassignTriggeredOnBlockSendFailure.set(true);
- }
+ postReassignTriggeredEvent(
+ partitionSplit ? reassignTriggeredOnPartitionSplit :
reassignTriggeredOnBlockSendFailure);
return internalHandle;
}
}
+ /** This method will check the historical state to avoid posting duplicate
events */
+ private void postReassignTriggeredEvent(AtomicBoolean tag) {
Review Comment:
Could u give a better name for `tag`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
