wForget commented on code in PR #2731:
URL: https://github.com/apache/uniffle/pull/2731#discussion_r2866892855
##########
common/src/main/java/org/apache/uniffle/common/netty/protocol/CompositeFileRegion.java:
##########
@@ -114,13 +112,7 @@ public boolean release(int decrement) {
}
@Override
- protected void deallocate() {
- for (FileRegion region : regions) {
- if (region instanceof AbstractReferenceCounted) {
- ((AbstractReferenceCounted) region).deallocate();
- }
- }
- }
+ protected void deallocate() {}
Review Comment:
`deallocate` is only called by the `release` method. Since we call
`regions.release` in the `release` method, we don't need to implement
`deallocate` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
