wForget commented on code in PR #2735:
URL: https://github.com/apache/uniffle/pull/2735#discussion_r2867096743
##########
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java:
##########
@@ -389,4 +389,11 @@ public class RssClientConf {
.defaultValue(-1)
.withDescription(
"Fetch seconds threshold for overlapping decompress shuffle
blocks.");
+
+ public static final ConfigOption<Integer>
+ RSS_READ_OVERLAPPING_DECOMPRESSION_MAX_CONCURRENT_SEGMENTS =
+
ConfigOptions.key("rss.client.read.overlappingDecompressionMaxConcurrentSegments")
+ .intType()
+ .defaultValue(-1)
Review Comment:
Should we set the default value to 1? That would make memory usage similar
to when overlapping disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
