xianjingfeng commented on code in PR #2742:
URL: https://github.com/apache/uniffle/pull/2742#discussion_r2963609751
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -494,50 +482,41 @@ public void updateCachedBlockIds(
}
ShuffleTaskInfo shuffleTaskInfo =
shuffleTaskInfos.computeIfAbsent(appId, x -> new
ShuffleTaskInfo(appId));
- long size = 0L;
- // With memory storage type should never need cachedBlockIds,
+ int blockCount = spbs.length -
shufflePartitionedData.getDuplicateBlockCount();
Review Comment:
Duplicated blocks will not be countd. @roryqi
Furthermore, based on the current code, the same block will not be committed
twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
