[
https://issues.apache.org/jira/browse/YUNIKORN-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074202#comment-17074202
]
Wilfred Spiegelenburg commented on YUNIKORN-31:
-----------------------------------------------
The lint check is also no working correctly on the core as it does not pull in
the correct reference form git to check against.
the makefile in both projects must be updated to run the following lint check:
{code}
golangci-lint run --new-from-rev=`git rev-parse --short=12 refs/heads/master`
{code}
> Turn on lint checks for k8shim
> ------------------------------
>
> Key: YUNIKORN-31
> URL: https://issues.apache.org/jira/browse/YUNIKORN-31
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
>
> The lint checks have been turned off for the k8shim.
> This means that new PRs are not checked against the code styles.
> Lots of new issues have been created due to not running lint checks on the
> code.
> The core is running the lint checks and so should the shim.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
