[
https://issues.apache.org/jira/browse/YUNIKORN-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095435#comment-17095435
]
Kinga Marton commented on YUNIKORN-93:
--------------------------------------
I have created two PRs for this issue (one for the core side and one for the
webapp side). [~akhilpb], [~wwei]/[~wilfreds] can you please help me with the
review?
I have addressed the following issues in the PR's:
[core side]
* corrected typos from
[queue_config.md|https://github.com/apache/incubator-yunikorn-core/blob/master/docs/queue_config.md]
* added a check for negative resources. There is already a check for total
resources to be greater than 0
* removed the hardcoded 20% for absolute used resource and added a calculated
value for each resource type what has a maximum resources defined
* added some test cases for this calculation
* refactored duplicated getQueueInfos method and made one recursive call. Also
I am returning only one QueueDAOInfo object, because there was no sense to keep
an array for it, because it contains only the root queue
[webapp side]
* set the queue label colour and the progress bar based on the max absolute
used resource value
* some smaller fixes as a consequence of the core side fixes
* showing 'N/A' instead of 0 if there is no value defined for the resources is
handled in YUNIKORN-113
> Queue maximum capacity cleanup
> ------------------------------
>
> Key: YUNIKORN-93
> URL: https://issues.apache.org/jira/browse/YUNIKORN-93
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Kinga Marton
> Assignee: Kinga Marton
> Priority: Major
> Labels: pull-request-available
>
> Right now the absolute used capacity is hardcoded to 20%.
> The usage bar is rendered by this value, but currently, it is hardcoded.
> Note, both capacity/max capacity could be 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
