[
https://issues.apache.org/jira/browse/YUNIKORN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098685#comment-17098685
]
Weiwei Yang commented on YUNIKORN-112:
--------------------------------------
Hi [~sunilg] ACK. Earlier we were not sure if we need the license header for
conf files. We might have more to fix in the web project. Another thing, we
have the license checker in the post-commit check, we need to modify that to
check these files too.
> Fix ASF release issues
> ----------------------
>
> Key: YUNIKORN-112
> URL: https://issues.apache.org/jira/browse/YUNIKORN-112
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: release
> Reporter: Weiwei Yang
> Priority: Blocker
>
> Felix gives us some feedback on our first release, we should make sure they
> are fixed in the next release, items include:
> - incubating in name
> - signature and hash fine
> - DISCLAIMER is ok - as above
> - LICENSE and NOTICE are fine
> - Ok with binary files - see note below
> - See note below on ASF headers
> - didn't compile from source
> 1. SHOULD: instead of a personal directory, release SHOULD be staged on
> [https://dist.apache.org/repos/dist/dev/incubator/yunikorn].
> [https://incubator.apache.org/guides/releasemanagement.html#podling_constraints]
> this include the signing KEYS file that should be kept as a project KEYS file
> instead of a personal one/location
> 2. it is a bit strange that you have 5 LICENSE files, you can exclude the one
> in subdirectories when you build the source tarball?
> 3. might want to check the license for the image files: png, jpg - where are
> they from?
> 4. SHOULD: a large number of files should also have ASF headers, eg. .mod,
> .yaml, .md, .go
> 5. nice to have: more details on go setup for dev environment (maybe just a
> quick link), go setup info without GoLand IDE. It could be helpful to know
> more on how to build (is this the build step?
> [https://github.com/apache/incubator-yunikorn-core/blob/master/docs/developer-guide.md#core-component-build])
> 6. SHOULD: put Apache Incubator logo on the
> websitehttps://[incubator.apache.org/guides/press-kit.html|http://incubator.apache.org/guides/press-kit.html]
> [http://yunikorn.apache.org/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
