[
https://issues.apache.org/jira/browse/YUNIKORN-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109722#comment-17109722
]
Wilfred Spiegelenburg commented on YUNIKORN-153:
------------------------------------------------
Sounds good, I am reviewing the change.
> Move updateRequest creation out of resource.go
> ----------------------------------------------
>
> Key: YUNIKORN-153
> URL: https://issues.apache.org/jira/browse/YUNIKORN-153
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Ting Yao,Huang
> Priority: Minor
> Labels: newbie, pull-request-available
>
> In the resource.go file we have a number of functions that are used to create
> {{si.UpdateRequest}}.
> these functions do not belong in the resource code and should be moved to a
> separate file with the test that belong to it also moved out of the
> resource_test.go file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
