[ 
https://issues.apache.org/jira/browse/YUNIKORN-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114372#comment-17114372
 ] 

Weiwei Yang commented on YUNIKORN-155:
--------------------------------------

Awesome, thanks [~kmarton], [~adam.antal]!

This is a good practice, I think we might need to implement more String() API 
for our structs.

The change looks good to me, but the UT pops up a new failure. We need a 
separate Jira to track that.

 

> data race in unit test: TestSchedulerRecoveryWhenPlacementRulesApplied
> ----------------------------------------------------------------------
>
>                 Key: YUNIKORN-155
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-155
>             Project: Apache YuniKorn
>          Issue Type: Test
>          Components: test - unit
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Kinga Marton
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: data_race.txt
>
>
> Testing shows a new data race while logging the queue name for an application 
> that gets added.
> Details in the attached logs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to