[ https://issues.apache.org/jira/browse/YUNIKORN-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114399#comment-17114399 ]
Weiwei Yang commented on YUNIKORN-158: -------------------------------------- Hi [~wilfreds] Thanks! I've tested this, looks like when I submitted the patch, I appended the --build-args to the docker build script for admission-controller image instead of the scheduler image. I just submitted another patch for this. > Admission controller deployment file should use the same version as the > scheduler > --------------------------------------------------------------------------------- > > Key: YUNIKORN-158 > URL: https://issues.apache.org/jira/browse/YUNIKORN-158 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: shim - kubernetes > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Priority: Major > Labels: pull-request-available > > Today, the admission controller is deployed as a post-start hook in the > scheduler pod, and the template file has hard coded docker image name, > [https://github.com/apache/incubator-yunikorn-k8shim/blob/b8a4a01fa1f6149c8617c914a721296a71037736/deployments/admission-controllers/scheduler/templates/server.yaml.template#L33.] > We should get this fixed and make sure the admission controller version is > always aligned with the scheduler. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org