[ https://issues.apache.org/jira/browse/YUNIKORN-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wilfred Spiegelenburg resolved YUNIKORN-289. -------------------------------------------- Fix Version/s: 0.9 Resolution: Fixed Multiple changes to fix the issue(s) found while investigating the sha issue: - replace shell script with Makefile - pull commit sha while building source tarball - make version push consistent - add admission controller version update https://github.com/apache/incubator-yunikorn-release/commit/b87f514a46923297221c7b3100c767dd67ba03ee > local build uses wrong sha > -------------------------- > > Key: YUNIKORN-289 > URL: https://issues.apache.org/jira/browse/YUNIKORN-289 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: release > Reporter: Wilfred Spiegelenburg > Assignee: Wilfred Spiegelenburg > Priority: Major > Fix For: 0.9 > > > When a {{replace}} is in the go.mod file the build does not handle is nicely > and the SHA that we retrieve for the docker build tag shows strange info: > {code} > go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f6 > 4ea58b502d38 => ../incubator > {code} > We only want the first part of the info. > The second thing we need to be careful with is the tag: if the semver tag > changes to include any dashes we will be generating the wrong info. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org