[ 
https://issues.apache.org/jira/browse/YUNIKORN-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186459#comment-17186459
 ] 

Kinga Marton commented on YUNIKORN-386:
---------------------------------------

I have one note for the part when we populate the application ID:
 * The application ID should be in the form of {{namespace-name}}, where both 
the namespace and the name must be the values of the app CRD, not the name of 
the spark pods.
 * when setting the name for the CRD, we have to make sure that the name does 
not have ''-", since we use it as separator.

> Pass applicationID for spark pods
> ---------------------------------
>
>                 Key: YUNIKORN-386
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-386
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>            Reporter: Kinga Marton
>            Assignee: Kinga Marton
>            Priority: Major
>         Attachments: spark-driver.PNG
>
>
> Right now we use {{spark-app-selector}} as the label for the applicationID 
> for Spark pods: 
> https://github.com/apache/incubator-yunikorn-k8shim/blob/master/pkg/common/utils/utils.go#L87
> When linking the Spark pod group to the CRD we use the Application ID, but 
> for the CRD we use {{namespace-name}} convention as ApplicationID and for the 
> spark pod group we use the {{spark-app-selector}} what will result in having 
> two different applications internally: one for the CRD and one for the Spark 
> POD group. 
> I think we should change this label to something else, what we can modify 
> easily without any side effects. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to