[ 
https://issues.apache.org/jira/browse/YUNIKORN-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430160#comment-17430160
 ] 

Weiwei Yang commented on YUNIKORN-872:
--------------------------------------

Hi [~ccondit] thanks for all the efforts.
there are a few more things I would suggest checking before merging this back 
to the master
# Need to check if this parameter is still applicable: 
https://github.com/apache/incubator-yunikorn-k8shim/blob/3a94fcbc1a0ea861e52c5da963e6d7a2f42302a3/pkg/conf/schedulerconf.go#L68.
# is there a testing plan for this? to make sure the predicates are all 
functional after the merge? e.g node affinity/anti-affinity, taints/toleration, 
ports, volumes, etc.


> [Umbrella] Build against kubernetes 1.20
> ----------------------------------------
>
>                 Key: YUNIKORN-872
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-872
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Craig Condit
>            Assignee: Craig Condit
>            Priority: Major
>
> Currently, the kubernetes shim is built against kubernetes 1.16. This version 
> has been end-of-life for quite some time now. We should update to build 
> against 1.20 prior to YuniKorn 1.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to