[ 
https://issues.apache.org/jira/browse/YUNIKORN-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500721#comment-17500721
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1102:
-------------------------------------------------

[~Tseng Hsi-Huang] this is caused by a typed nil being returned. The typed nil 
is not considered a nil for the interface. Please reverse that part. We need to 
have a separate look at these interfaces used. There seems to be just one 
implementation so we might be able to clean up. Not for this JIRA!

> shim context getTask error is ignored
> -------------------------------------
>
>                 Key: YUNIKORN-1102
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1102
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Tseng Hsi-Huang
>            Priority: Major
>              Labels: newbie
>
> The {{context.getTask()}} call returns a {{Task}} struct and an error. In all 
> cases either the task is nil or the error is nil. The error returned is also 
> fixed and does not provide any detail not known without it (i.e. "application 
> is not found" which only partially covers the cases)
> We need to bring the call in line with _GetApplication_ and the _GetNode_ in 
> the cache and just return the task and handle the nil return.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to