[
https://issues.apache.org/jira/browse/YUNIKORN-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507471#comment-17507471
]
Peter Bacsko commented on YUNIKORN-1122:
----------------------------------------
One more thought from me: there is a attribute which is defined separately in
the core and shim, namely the "ready" setting, see:
https://github.com/apache/incubator-yunikorn-core/blob/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a/pkg/scheduler/objects/node.go#L36
https://github.com/apache/incubator-yunikorn-k8shim/blob/af2fb201048bb9798501da4d62517098a91e7b41/pkg/common/constants/constants.go#L26
This could be moved to the SI, too.
> Move constants to scheduler interface
> -------------------------------------
>
> Key: YUNIKORN-1122
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1122
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common, scheduler-interface, shim - kubernetes
> Reporter: Weiwei Yang
> Assignee: TingYao Huang
> Priority: Major
>
> While reviewing YUNIKORN-1103, I found there are quite some constants are
> still defined in shim/core repo. Since we have the ability to define
> constants in SI, we should move all COMMON constants to SI.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
