[ https://issues.apache.org/jira/browse/YUNIKORN-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wilfred Spiegelenburg resolved YUNIKORN-2054. --------------------------------------------- Fix Version/s: 1.4.0 Resolution: Fixed Change committed with a fix for the spelling mistake > Shim: Fix dependencies in Makefile > ---------------------------------- > > Key: YUNIKORN-2054 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2054 > Project: Apache YuniKorn > Issue Type: Bug > Components: shim - kubernetes > Reporter: Craig Condit > Assignee: Craig Condit > Priority: Blocker > Labels: newbie, pull-request-available > Fix For: 1.4.0 > > > The Makefile dependency lists for generated binary targets is incorrect: > {code:java} > $(DEV_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum pkg > $(DEV_BIN_DIR)/$(PLUGIN_BINARY): go.mod go.sum pkg > $(RELEASE_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum pkg > $(RELEASE_BIN_DIR)/$(PLUGIN_BINARY): go.mod go.sum pkg > $(RELEASE_BIN_DIR)/$(ADMISSION_CONTROLLER_BINARY): go.mod go.sum pkg > $(DEV_BIN_DIR)/$(TEST_SERVER_BINARY): go.mod go.sum pkg > $(RELEASE_BIN_DIR)/$(TEST_SERVER_BINARY): go.mod go.sum pkg{code} > All instances of "pkg" should be changed to "$(shell find pkg)": > {code:java} > ...: go.mod go.sum $(shell find pkg){code} > See PR from YUNIKORN-1927 for an example. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org