[ 
https://issues.apache.org/jira/browse/YUNIKORN-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PoAn Yang resolved YUNIKORN-2137.
---------------------------------
     Fix Version/s: 1.4.0
    Target Version: 1.4.0
        Resolution: Fixed

Merged to master. Thanks [~targetoee] for the contribution.

> Remove defer cleanup in checkLimits
> -----------------------------------
>
>                 Key: YUNIKORN-2137
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2137
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: PoAn Yang
>            Assignee: JiaChi Wang
>            Priority: Minor
>              Labels: newbie, pull-request-available
>             Fix For: 1.4.0
>
>
> Code Reference: 
> [https://github.com/apache/yunikorn-core/blob/30e69f97585bc3a82f4b9c54f4cc4b601120a776/pkg/common/configs/configvalidator.go#L586-L594]
> Slack Reference: 
> [https://yunikornworkspace.slack.com/archives/CL9CRJ1KM/p1699430436233019]
>  
> The {{existedUserName}} and {{existedGroupName}} in {{checkLimits}} will be 
> GC after the goroutine leaves the function. It's safe to remove the defer 
> function.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to