Peter Bacsko created YUNIKORN-2423: -------------------------------------- Summary: Remove unnecessary boolean return value from the tracking code Key: YUNIKORN-2423 URL: https://issues.apache.org/jira/browse/YUNIKORN-2423 Project: Apache YuniKorn Issue Type: Sub-task Components: core - scheduler Reporter: Peter Bacsko
QueueTracker has two methods which both have an unnecessary return value: {noformat} increaseTrackedResource() bool decreaseTrackedResource() (bool, bool) {noformat} The value from {{increaseTrackedResource()}} is always true. It used to be different, but it no longer has any relevance. Same goes for {{{}decreaseTrackedResource(){}}}, only the first boolean can change which indicates whether a tracker can be removed. Also, {{UserTracker.increaseTrackedResource()}} can be simplified as the increment always succeeds and does not need to return anything: {noformat} unc (ut *UserTracker) increaseTrackedResource(queuePath string, applicationID string, usage *resources.Resource) bool { ut.Lock() defer ut.Unlock() hierarchy := strings.Split(queuePath, configs.DOT) ut.events.sendIncResourceUsageForUser(ut.userName, queuePath, usage) increased := ut.queueTracker.increaseTrackedResource(hierarchy, applicationID, user, usage) if increased { ... // branch always taken } return increased } {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org