[ https://issues.apache.org/jira/browse/YUNIKORN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821725#comment-17821725 ]
Yu-Lin Chen edited comment on YUNIKORN-1351 at 2/28/24 3:36 PM: ---------------------------------------------------------------- Hi [~ccondit], Just updated the version 2. * PDF: [^[Design Doc][v2] Define policy for when to use annotations vs labels.pdf] Please feel free to add comment in the Google Doc link: * Google Doc: [link|https://docs.google.com/document/d/1SDIKF_4BLKFDWrZtQL1yr8I7KZkOhS99Fb7i0Ge6Uqw/edit?usp=sharing] Major changes: # Utilize canonical representation and establish naming rules. (No deprecation) # Add more description for backward compatibility # Describe the changes in Admission Controller. Adding new AM configuration 'admissionController.webhook.disableCanonicalMetadataOnPod' for backward compatibility. was (Author: yu-lin chen): Hi [~ccondit], Just updated the version 2. * PDF: [^[Design Doc][v2] Define policy for when to use annotations vs labels.pdf] Please feel free to add comment in the Google Doc link: * Google Doc: [link|https://docs.google.com/document/d/1SDIKF_4BLKFDWrZtQL1yr8I7KZkOhS99Fb7i0Ge6Uqw/edit?usp=sharing] Major changes: # Utilize canonical representation and establish naming rules. (No deprecation) # Add more description for backward compatibility # Describe the changes in Admission Controller. Adding new AM configuration 'admissionController.webhook.disableCanonicalMetadataOnPod' for backward compatibility. > Define policy for when to use annotations vs. labels > ---------------------------------------------------- > > Key: YUNIKORN-1351 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1351 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes > Reporter: Wilfred Spiegelenburg > Assignee: Yu-Lin Chen > Priority: Major > Labels: newbie, pull-request-available > Attachments: [Design Doc] Define Usage of Labels and Annotations in > YuniKorn.pdf, [Design Doc][v2] Define policy for when to use annotations vs > labels.pdf > > > Currently, we have very inconsistent use of labels vs. annotations in > YuniKorn. Additionally, some values are namespaced under yunikorn.apache.org > while some are not. We will likely need to keep legacy values around for > backwards compatibility but we should define a strategy for defining > canonical representations of this metadata as well as a developer-oriented > pollcy around when to use labels vs. annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org