[ https://issues.apache.org/jira/browse/YUNIKORN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821817#comment-17821817 ]
Yu-Lin Chen commented on YUNIKORN-1351: --------------------------------------- Hi [~ccondit], Thanks for the detailed feedback. I agree with this statement: * "We can infer that if a user has not supplied an Application ID explicitly, they are not concerned with where that metadata gets stored." I will remove the new AM config change in the document and write down the plan for changing if there are no objections in the next few days. Here I only have one thing to correct, this statement is incorrect * -The admission controller currently *only* sets the Application ID- Admission controller also set the default queue name. The AM config "admissionController.filtering.defaultQueue" allows AM to patch different default queue name.(Code: [pkg/admission/util.go#L62-L63|https://github.com/apache/yunikorn-k8shim/blob/master/pkg/admission/util.go#L62-L63]) Based on the same reason for Application ID, the support for queue should be the same. * Queue ** *{{yunikorn.apache.org/queue}} [label] –{color:#de350b} generated by AM in 1.6.0+{color}* ** {{yunikorn.apache.org/queue}} [annotation] ** {{queue }}[label] – {color:#de350b}generated by AM in 1.6.0, not in 1.7.0+{color} For the others, we are in the same page. > Define policy for when to use annotations vs. labels > ---------------------------------------------------- > > Key: YUNIKORN-1351 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1351 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes > Reporter: Wilfred Spiegelenburg > Assignee: Yu-Lin Chen > Priority: Major > Labels: pull-request-available > Attachments: [Design Doc] Define Usage of Labels and Annotations in > YuniKorn.pdf, [Design Doc][v2] Define policy for when to use annotations vs > labels.pdf > > > Currently, we have very inconsistent use of labels vs. annotations in > YuniKorn. Additionally, some values are namespaced under yunikorn.apache.org > while some are not. We will likely need to keep legacy values around for > backwards compatibility but we should define a strategy for defining > canonical representations of this metadata as well as a developer-oriented > pollcy around when to use labels vs. annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org