[ https://issues.apache.org/jira/browse/YUNIKORN-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840555#comment-17840555 ]
Hsien-Cheng(Ryan) Huang commented on YUNIKORN-2577: --------------------------------------------------- Looks like `PreemptionPredicates` has a similar issue as `GetPodNoLock`. > Remove named returns from IsPodFitNodeViaPreemption > --------------------------------------------------- > > Key: YUNIKORN-2577 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2577 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes > Reporter: Wilfred Spiegelenburg > Assignee: Hsien-Cheng(Ryan) Huang > Priority: Minor > Labels: newbie, pull-request-available > > IsPodFitNodeViaPreemption has defined named returns but does not use them. > They should be removed as the way they are used can cause issues that are > hard to debug. > As part of this change we need to further cleanup: > * The variable {{ok}} also gets shadowed multiple times, not just from the > named return declaration. > * The if construct around {{GetPodNoLock()}} is not needed as it returns a > nil for the pod if it returns false. Just adding the result for the pod > always has the same effect. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org