[ 
https://issues.apache.org/jira/browse/YUNIKORN-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860326#comment-17860326
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-2704:
-------------------------------------------------

And on the k8shim side we have simply defaulted to [empty 
strings|https://github.com/apache/yunikorn-k8shim/blob/e59162db4067bf2b0997c49d665eaafd50fc4aa6/pkg/cache/context.go#L1188-L1190]
{code:java}
                if task := ctx.getTask(appID, taskID); task != nil {
                    events.GetRecorder().Eventf(task.GetTaskPod().DeepCopy(), 
nil,
                        v1.EventTypeNormal, "", "", record.Message) {code}
While for the node events we set a value always:
{code:java}
                events.GetRecorder().Eventf(node.DeepCopy(), nil,
                    v1.EventTypeNormal, "Informational", "Informational", 
record.Message) {code}

> Event publish errors out when predicates fail
> ---------------------------------------------
>
>                 Key: YUNIKORN-2704
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2704
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Mit Desai
>            Assignee: Peter Bacsko
>            Priority: Major
>
> I consistently see this error in the logs when events are published.
> I did put some debug logs and found that I only get it when the events for 
> untolerated taints are published.
> E0618 17:43:17.858946       1 event_broadcaster.go:270] "Server rejected 
> event (will not retry!)" err="Event \"<<pod-name>>.17da2a31072bb32f\" is 
> invalid: [action: Required value, reason: Required value]" 
> event="&Event\{ObjectMeta:{<<pod-name>>.17da2a31072bb32f  dpi-dev    0 
> 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] 
> []},EventTime:2024-06-18 17:43:17.857332069 +0000 UTC 
> m=+84279.014490005,Series:nil,ReportingController:yunikorn,ReportingInstance:yunikorn-yunikorn-scheduler-59bdc88fdc-7h5bt,Action:,Reason:,Regarding:\{Pod
>  <<namespace>> <<pod-name>> 5c90315c-a07d-4801-9ecc-baf61ee45f11 v1 
> 4323324038 },Related:nil,Note:Predicate failed for request 
> '5c90315c-a07d-4801-9ecc-baf61ee45f11' with message: 'node(s) had untolerated 
> taint \{<<key>>: <<value>>}',Type:Normal,DeprecatedSource:\{ 
> },DeprecatedFirstTimestamp:0001-01-01 00:00:00 +0000 
> UTC,DeprecatedLastTimestamp:0001-01-01 00:00:00 +0000 UTC,DeprecatedCount:0,}"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to