[ 
https://issues.apache.org/jira/browse/YUNIKORN-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yu-Lin Chen updated YUNIKORN-2504:
----------------------------------
    Description: 
Currently, we support queue/applicationID set in both label and annotation.

Queue
 * queue [label] → {color:#de350b}If set, ignore annotation’s value{color}
 * yunikorn.apache.org/queue [annotation]

ApplicationID
 * applicationId [label]
 * yunikorn.apache.org/app-id [annotation] → {color:#de350b}If set, ignore 
label’s value{color}

According to the new policy defined in YUNIKORN-1351.

We will add *canonical representation* to Queue/ApplicationId:
 * yunikorn.apache.org/queue [label]
 * yunikorn.apache.org/app-id [label]

Non-canonical format will be kept for backward compatibility.
However, If the same metadata (queue or applicationID) is specified in multiple 
locations and their values are inconsistent, the admission controller and 
scheduler should reject the pod. ({*}Version 1.6.0 only prints out warnings; 
task rejection should occur in version 1.7.0{*}.)

 

Also align the ordering when fetch app-id/queue from pod:

app-id should be fetched in below order:
 # Label: yunikorn.apache.org/app-id ({*}New{*})
 # Annotation: yunikorn.apache.org/app-id
 # Label: applicationId
 # Label: spark-app-selector

queue name should be fetched in below order:
 # Label: yunikorn.apache.org/queue ({*}New{*})
 # Annotation: yunikorn.apache.org/queue
 # Label: queue

 

Please refer the changes in YUNIKORN-1351 for more details.

  was:
Currently, we support queue/applicationID set in both label and annotation.

Queue
 * queue [label] → {color:#de350b}If set, ignore annotation’s value{color}
 * yunikorn.apache.org/queue [annotation]

ApplicationID
 * applicationId [label]
 * yunikorn.apache.org/app-id [annotation] → {color:#de350b}If set, ignore 
label’s value{color}

According to the new policy defined in YUNIKORN-1351.

We will add *canonical representation* to Queue/ApplicationId:
 * yunikorn.apache.org/queue [label]
 * yunikorn.apache.org/app-id [label]

Non-canonical format will be kept for backward compatibility.
However, If the same metadata (queue or applicationID) is specified in multiple 
locations and their values are inconsistent, the admission controller and 
scheduler should reject the pod.

Admission controller should only patch canonical representation in the future 
release, please refer the changes in YUNIKORN-1351’s policy document(‘What will 
be changed’ → ‘Admission Controller Changes).


> Support canonical labels for queue/applicationId in scheduler
> -------------------------------------------------------------
>
>                 Key: YUNIKORN-2504
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2504
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - scheduler, release-notes, shim - kubernetes
>            Reporter: Yu-Lin Chen
>            Assignee: Yu-Lin Chen
>            Priority: Major
>              Labels: pull-request-available, release-notes
>
> Currently, we support queue/applicationID set in both label and annotation.
> Queue
>  * queue [label] → {color:#de350b}If set, ignore annotation’s value{color}
>  * yunikorn.apache.org/queue [annotation]
> ApplicationID
>  * applicationId [label]
>  * yunikorn.apache.org/app-id [annotation] → {color:#de350b}If set, ignore 
> label’s value{color}
> According to the new policy defined in YUNIKORN-1351.
> We will add *canonical representation* to Queue/ApplicationId:
>  * yunikorn.apache.org/queue [label]
>  * yunikorn.apache.org/app-id [label]
> Non-canonical format will be kept for backward compatibility.
> However, If the same metadata (queue or applicationID) is specified in 
> multiple locations and their values are inconsistent, the admission 
> controller and scheduler should reject the pod. ({*}Version 1.6.0 only prints 
> out warnings; task rejection should occur in version 1.7.0{*}.)
>  
> Also align the ordering when fetch app-id/queue from pod:
> app-id should be fetched in below order:
>  # Label: yunikorn.apache.org/app-id ({*}New{*})
>  # Annotation: yunikorn.apache.org/app-id
>  # Label: applicationId
>  # Label: spark-app-selector
> queue name should be fetched in below order:
>  # Label: yunikorn.apache.org/queue ({*}New{*})
>  # Annotation: yunikorn.apache.org/queue
>  # Label: queue
>  
> Please refer the changes in YUNIKORN-1351 for more details.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to