[ https://issues.apache.org/jira/browse/YUNIKORN-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated YUNIKORN-2724: ------------------------------------- Labels: pull-request-available (was: ) > Improve the signature of methods notifyTaskComplete() and > ensureAppAndTaskCreated() > ----------------------------------------------------------------------------------- > > Key: YUNIKORN-2724 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2724 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes > Reporter: Peter Bacsko > Assignee: Hsien-Cheng(Ryan) Huang > Priority: Minor > Labels: pull-request-available > > From the review [https://github.com/apache/yunikorn-k8shim/pull/864] > Change {{notifyTaskComplete(string, string)}} to > {{notifyTaskComplete(*Application, string).}} It removes a number of extra > getApplication() calls we really do not need. > Similar for {{ensureAppAndTaskCreated()}} which is only ever called from this > function. Add a parameter to it to make it: > {{ensureAppAndTaskCreated(*v1.Pod, *Application)}} and only execute > application creation {{{}if app == nil{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org