[ https://issues.apache.org/jira/browse/YUNIKORN-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875392#comment-17875392 ]
Tzu-Hua Lan commented on YUNIKORN-2824: --------------------------------------- Hi, would like to take this issue. Thank you. > Refactor preemption_test.go > --------------------------- > > Key: YUNIKORN-2824 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2824 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: core - scheduler > Reporter: Manikandan R > Priority: Major > > Off late, lot of new tests has been added into preemption_test.go for several > use cases. There is a room of improvement to simplify the whole tests > especially by avoiding duplicates. For example, > TestTryPreemption, TestTryPreemptionOnNode and > TestTryPreemption_NodeWithCapacityLesserThanAsk can be merged together into > single one and handle each cases through t.Run({}) construct. > Need to analyse other tests as well and see if those can be merged together > for simplification. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org