[ 
https://issues.apache.org/jira/browse/YUNIKORN-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875898#comment-17875898
 ] 

Yu-Lin Chen commented on YUNIKORN-2819:
---------------------------------------

After discussed with [~blue.tzuhua], we realized that helm doesn't support 
below configuration in values.yaml:


{code:java}
version: "1.5.0"
image:
  repository: local/yunikorn
  tag: scheduler-${version}{code}

If we make the templates read the version parameter in tag filed, we might lose 
the backward compatibility of setting image tag through below command:

{code:java}
helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
  --set image.tag=scheduler-${VERSION} \
  --set pluginImage.tag=scheduler-plugin-${VERSION} 
  --set admissionController.image.tag=admission-${VERSION} \
  --set web.image.tag=web-${VERSION}
{code}

So I will resolve this Jira to "Won't Do".

> Add version parameter to Helm chart
> -----------------------------------
>
>                 Key: YUNIKORN-2819
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2819
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: helm chart
>            Reporter: Yu-Lin Chen
>            Assignee: Tzu-Hua Lan
>            Priority: Major
>
> This is a followup of this [PR 
> discussion|https://github.com/apache/yunikorn-site/pull/452#issuecomment-2295808375].
> When install YuniKorn with Helm, if we want to install different version of 
> YuniKorn, we have to specifify the image tags one by one, for example:
>  
> {code:java}
> VERSION=1.5.2
> helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
>   --set image.tag=scheduler-${VERSION} \
>   --set pluginImage.tag=scheduler-plugin-${VERSION} 
>   --set admissionController.image.tag=admission-${VERSION} \
>   --set web.image.tag=web-${VERSION} {code}
>  
> It's would be better if we can set the version for all the image tags at once:
> {code:java}
> VERSION=1.5.2
> helm install yunikorn yunikorn/yunikorn --namespace yunikorn \
>   --set version=${VERSION} {code}
>  
> [https://github.com/apache/yunikorn-release/tree/master/helm-charts/yunikorn#configuration]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to