[ 
https://issues.apache.org/jira/browse/YUNIKORN-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876912#comment-17876912
 ] 

Tzu-Hua Lan commented on YUNIKORN-2840:
---------------------------------------

Hi, would like to take this issue. Thank you.

> sortQueues: fair max performance and correctness change
> -------------------------------------------------------
>
>                 Key: YUNIKORN-2840
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2840
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Priority: Major
>
> In YUNIKORN-2678 the fair queue sorting was improved to take guaranteed quota 
> into account correctly. During the review there were two minor points left 
> over that would need improving:
>  * performance
>  * correctness on changeĀ 
> Currently {{GetFairMaxResource()}} gets called for each child this does a 
> recursive call back up the queue hierarchy. This is a performance loss 
> specially when sorting a deep hierarchy or a larger number of children.
> The parent details for a real fair comparison between the children should 
> also not change. When they do, as in the current implementation, two children 
> might use different inputs when sorted.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to