[
https://issues.apache.org/jira/browse/YUNIKORN-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated YUNIKORN-3372:
-------------------------------------
Labels: pull-request-available (was: )
> Event-stream tests create a stream via CreateEventStream and never call
> RemoveStream, leaking the forwarder goroutine
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: YUNIKORN-3372
> URL: https://issues.apache.org/jira/browse/YUNIKORN-3372
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: test - unit
> Reporter: Dale Richardson
> Assignee: weichen lai
> Priority: Minor
> Labels: pull-request-available
>
> Split from YUNIKORN-3364 per the PR #1124 review: the
> {{events.(*EventStreaming).CreateEventStream}} leakcheck exemption has two
> causes, and this is the test-only one. Tests that open an event stream via
> {{EventStreaming.CreateEventStream}} never call {{{}RemoveStream{}}}, so the
> forwarder goroutine outlives the test binary. Distinct from the production
> history-replay defect (YUNIKORN-3364).
> Proposed fix: have those tests {{{}defer <streaming>.RemoveStream(...){}}}.
> Together with YUNIKORN-3364 this deletes the {{CreateEventStream}} exemption
> in {{{}pkg/common/leakcheck/leakcheck.go{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
