[ 
https://issues.apache.org/jira/browse/YUNIKORN-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116589#comment-18116589
 ] 

Andy Huang commented on YUNIKORN-3461:
--------------------------------------

Could you clarify the intended behavior here? Currently, `newPlaceholder()` 
copies the `yunikorn.apache.org/task-groups` annotation to generated 
placeholder pods to support recovery. This means legitimate placeholders can 
have both task-group definitions and 
`internal.yunikorn.apache.org/placeholder=true`

Is the proposed restriction intended to apply only to user-submitted originator 
pods? If so, how should we distinguish them from generated placeholders 
carrying the same annotations? 

Also, when an originator pod has the placeholder flag set, should the shim 
reject the pod or ignore the flag and treat it as a regular originator?

> Originator can have placeholder flag set
> ----------------------------------------
>
>                 Key: YUNIKORN-3461
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-3461
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Andy Huang
>            Priority: Major
>
> The {{internal.yunikorn.apache.org/placeholder=true}} can be specified on any 
> pod in the system. If the pod does not have a taskgroup name set it will be 
> rejected by the core when submitted.
> The originator pod, that has the taskgroup definitions, could also have the 
> same label set. This is not correct and will have an undefined behaviour on 
> gang scheduling.
> A pod should not have the placeholder flag if it has the taskgroup 
> definitions included.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to