[ https://issues.apache.org/jira/browse/ZOOKEEPER-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890597#comment-16890597 ]
Asutosh Pandya commented on ZOOKEEPER-3457: ------------------------------------------- [https://github.com/apache/zookeeper/pull/1020] > Code optimization in QuorumCnxManager > ------------------------------------- > > Key: ZOOKEEPER-3457 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3457 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Affects Versions: 3.5.5 > Reporter: tom.long > Priority: Trivial > Labels: easyfix, pull-request-available > Fix For: 3.5.5 > > Original Estimate: 1h > Remaining Estimate: 1h > > Dear developer: > I think the following code in line 623 of the QuorumCnxManager class can be > optimized: > {code:java} > ArrayBlockingQueue<ByteBuffer> bq = new ArrayBlockingQueue<ByteBuffer>( > SEND_CAPACITY); > ArrayBlockingQueue<ByteBuffer> oldq = queueSendMap.putIfAbsent(sid, bq); > if (oldq != null) { > addToSendQueue(oldq, b); > } else { > addToSendQueue(bq, b); > } > {code} > The optimization is as follows: > {code:java} > ArrayBlockingQueue<ByteBuffer> bq = queueSendMap.computeIfAbsent(sid, > serverId > -> new ArrayBlockingQueue<>(SEND_CAPACITY)); > addToSendQueue(bq, b); > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)