[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mate Szalay-Beko updated ZOOKEEPER-3530:
----------------------------------------
    Description: 
After ZOOKEEPER-3436 is merged, maven will build the C-client and put them 
under the folder {{zookeeper-client/zookeeper-client-c/target/c}}.

During the old ZooKeeper 3.4 ant builds ({{ant package-native}}), there was an 
artifact ({{zookeeper-<version>-lib.tar.gz}}) created just for the C-client, 
with the following content:
{code:bash}
usr
  |--- bin
         |--- cli_mt
         |--- cli_st
         |--- load_gen
  |--- include
         |--- zookeeper
                |--- proto.h
                |--- recordio.h
                |--- zookeeper.h
                |--- zookeeper.jute.h
                |--- zookeeper_log.h
                |--- zookeeper_version.h
  |--- lib
         |--- libzookeeper_mt.a
         |--- libzookeeper_mt.la
         |--- libzookeeper_mt.so
         |--- libzookeeper_mt.so.2
         |--- libzookeeper_mt.so.2.0.0
         |--- libzookeeper_st.a
         |--- libzookeeper_st.la
         |--- libzookeeper_st.so
         |--- libzookeeper_st.so.2
         |--- libzookeeper_st.so.2.0.0
{code}

Currently with maven, when we are generating a tarball during full-build then 
the C-client is not getting archived. In 
[PR-1078|https://github.com/apache/zookeeper/pull/1078] we discussed that we 
should re-introduce the {{apache-zookeeper-<version>-lib.tar.gz}} artifact.

  was:
After ZOOKEEPER-3436 is merged, maven will build the C-client and put them 
under the folder {{zookeeper-client/zookeeper-client-c/target/c}}.

During the old ZooKeeper 3.4 ant builds ({{ant package-native}}), there was an 
artifact ({{zookeeper-<version>-lib.tar.gz}}) created just for the C-client, 
with the following content:
{code:bash}
usr
  |--- bin
         |--- cli_mt
         |--- cli_st
         |--- load_gen
  |--- include
         |--- zookeeper
                |--- proto.h
                |--- recordio.h
                |--- zookeeper.h
                |--- zookeeper.jute.h
                |--- zookeeper_log.h
                |--- zookeeper_version.h
  |--- lib
         |--- libzookeeper_mt.a
         |--- libzookeeper_mt.la
         |--- libzookeeper_mt.so
         |--- libzookeeper_mt.so.2
         |--- libzookeeper_mt.so.2.0.0
         |--- libzookeeper_st.a
         |--- libzookeeper_st.la
         |--- libzookeeper_st.so
         |--- libzookeeper_st.so.2
         |--- libzookeeper_st.so.2.0.0
{code}
Currently with maven, when we are generating a tarball during full-build using 
e.g. the {{mvn clean install -DskipTests -Pfull-build}} command, then the 
C-client is not getting archived. In 
[PR-1078|https://github.com/apache/zookeeper/pull/1078] we discussed that we 
should re-introduce the {{apache-zookeeper-<version>-lib.tar.gz}} artifact.


> Include compiled C-client in the binary tarball
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-3530
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3530
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.6.0, 3.5.7
>            Reporter: Mate Szalay-Beko
>            Assignee: Mate Szalay-Beko
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> After ZOOKEEPER-3436 is merged, maven will build the C-client and put them 
> under the folder {{zookeeper-client/zookeeper-client-c/target/c}}.
> During the old ZooKeeper 3.4 ant builds ({{ant package-native}}), there was 
> an artifact ({{zookeeper-<version>-lib.tar.gz}}) created just for the 
> C-client, with the following content:
> {code:bash}
> usr
>   |--- bin
>          |--- cli_mt
>          |--- cli_st
>          |--- load_gen
>   |--- include
>          |--- zookeeper
>                 |--- proto.h
>                 |--- recordio.h
>                 |--- zookeeper.h
>                 |--- zookeeper.jute.h
>                 |--- zookeeper_log.h
>                 |--- zookeeper_version.h
>   |--- lib
>          |--- libzookeeper_mt.a
>          |--- libzookeeper_mt.la
>          |--- libzookeeper_mt.so
>          |--- libzookeeper_mt.so.2
>          |--- libzookeeper_mt.so.2.0.0
>          |--- libzookeeper_st.a
>          |--- libzookeeper_st.la
>          |--- libzookeeper_st.so
>          |--- libzookeeper_st.so.2
>          |--- libzookeeper_st.so.2.0.0
> {code}
> Currently with maven, when we are generating a tarball during full-build then 
> the C-client is not getting archived. In 
> [PR-1078|https://github.com/apache/zookeeper/pull/1078] we discussed that we 
> should re-introduce the {{apache-zookeeper-<version>-lib.tar.gz}} artifact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to