maoling created ZOOKEEPER-3728: ---------------------------------- Summary: move traceMask calculation logic into the trace log in the FinalRequestProcessor#processRequest Key: ZOOKEEPER-3728 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3728 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: maoling
{code:java} LOG.debug("Processing request:: {}", request); // request.addRQRec(">final"); long traceMask = ZooTrace.CLIENT_REQUEST_TRACE_MASK; if (request.type == OpCode.ping) { traceMask = ZooTrace.SERVER_PING_TRACE_MASK; } if (LOG.isTraceEnabled()) { ZooTrace.logRequest(LOG, traceMask, 'E', request, ""); } {code} # remove the useless *// request.addRQRec(">final");* # most read/write requests will hit the code here but useless when Log Trace disable. we need to move traceMask calculation logic into the LOG.isTraceEnabled() -- This message was sent by Atlassian Jira (v8.3.4#803005)