[
https://issues.apache.org/jira/browse/ZOOKEEPER-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated ZOOKEEPER-4651:
----------------------------------------
Description:
Checkstyle was upgraded to 8.39 in ZOOKEEPER-4644 and it doesn't work properly
on current branch 3.6. Given that branch 3.6 won't be actively developed in the
future, I decided to downgrade checkstyle back to 8.19 instead of fixing the
checkstyle config or re-format the code.
But even after downgrade, checkstyle fails on branch-3.6 with the following
error. We need to fix it before release 3.6.4
{code:java}
[INFO] There are 4 errors reported by Checkstyle 8.19 with
checkstyle-strict.xml ruleset.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
(javadoc) JavadocParagraph: <p> tag should be placed immediately before the
first word, with no space after.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
(javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
(javadoc) JavadocParagraph: <p> tag should be placed immediately before the
first word, with no space after.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
(javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
(...)
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (default-cli) on
project zookeeper-compatibility-tests-curator: You have 4 Checkstyle
violations. -> [Help 1]
{code}
was:
checkstyle fails on branch-3.6, need to fix it before release 3.6.4
{code:java}
[INFO] There are 4 errors reported by Checkstyle 8.19 with
checkstyle-strict.xml ruleset.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
(javadoc) JavadocParagraph: <p> tag should be placed immediately before the
first word, with no space after.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
(javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
(javadoc) JavadocParagraph: <p> tag should be placed immediately before the
first word, with no space after.
[ERROR]
src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
(javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
(...)
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (default-cli) on
project zookeeper-compatibility-tests-curator: You have 4 Checkstyle
violations. -> [Help 1]
{code}
> Fix checkstyle problems on branch-3.6
> -------------------------------------
>
> Key: ZOOKEEPER-4651
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4651
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Mate Szalay-Beko
> Assignee: Mate Szalay-Beko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Checkstyle was upgraded to 8.39 in ZOOKEEPER-4644 and it doesn't work
> properly on current branch 3.6. Given that branch 3.6 won't be actively
> developed in the future, I decided to downgrade checkstyle back to 8.19
> instead of fixing the checkstyle config or re-format the code.
> But even after downgrade, checkstyle fails on branch-3.6 with the following
> error. We need to fix it before release 3.6.4
> {code:java}
> [INFO] There are 4 errors reported by Checkstyle 8.19 with
> checkstyle-strict.xml ruleset.
> [ERROR]
> src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
> (javadoc) JavadocParagraph: <p> tag should be placed immediately before the
> first word, with no space after.
> [ERROR]
> src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9]
> (javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
> [ERROR]
> src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
> (javadoc) JavadocParagraph: <p> tag should be placed immediately before the
> first word, with no space after.
> [ERROR]
> src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11]
> (javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
> (...)
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (default-cli) on
> project zookeeper-compatibility-tests-curator: You have 4 Checkstyle
> violations. -> [Help 1]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
