[
https://issues.apache.org/jira/browse/ZOOKEEPER-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kezhu Wang resolved ZOOKEEPER-3058.
-----------------------------------
Resolution: Won't Fix
Comments in pr pointed the the proposal breaks result of current behavior.
> Do length check first before actual byte check in compareBytes method of
> Utils class
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3058
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3058
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jute
> Reporter: Hosur Narahari
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In compareBytes method of org.apache.jute.Utils class, all the individual
> bytes of 2 byte arrays are compared and then their lengths are compared. We
> can improve the performance by first having length check, since we can rule
> out that they aren't equal by a single if condition(O(1) operation) rather
> than looping through arrays(O( n ) operation).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
