commit c5f2943ff6f3d506a06a896ab634063bff223af0
Author: Oswald Buddenhagen <o...@users.sf.net>
Date:   Sat Apr 12 15:28:28 2014 +0200

    don't crash in message expiration debug print
    
    we would try to print the uids from the non-existing srec of unpaired
    messages while preparing expiration.
    this would happen only if a) MaxMessages was configured and b) new
    messages appeared on the slave but we were not pushing, so it's a bit of
    a corner case.
    
    found by coverity.

 src/sync.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/sync.c b/src/sync.c
index 851b2db..cdd6c3d 100644
--- a/src/sync.c
+++ b/src/sync.c
@@ -1360,7 +1360,7 @@ box_loaded( int sts, void *aux )
                                continue;
                        if (!(srec = tmsg->srec) || srec->uid[M] <= 0) {
                                /* We did not push the message, so it must be 
kept. */
-                               debug( "  old pair(%d,%d) unpropagated\n", 
srec->uid[M], srec->uid[S] );
+                               debug( "  message %d unpropagated\n", tmsg->uid 
);
                                todel--;
                        } else {
                                nflags = (tmsg->flags | srec->aflags[S]) & 
~srec->dflags[S];

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel

Reply via email to