Hello all,
Apologies for the delay! Been out studying and touching grass.
Regarding the use of unions vs pragmas here, it seems the preferred
method of suppressing the warning is still via pragmas, so I'll continue
their use. Let me know if anyone still desires the union approach.
Regarding the problematic cast, it may be better to perform it on return
rather than immediately. That is, retaining the const qualifier until
the return statement, at which point we remove it. This can add a
little more safety, as it ensures the value isn't modified within the
function. Any thoughts?
And while we're modifying the local variables, I'd like to change their
type from u_char* to either unsigned char* or uint8_t*. If a typedef
must be used, I see no reason to use the nonstandard u_char when there's
the equivalent C-standard uint8_t.
Take care,
Seth McDonald.
--
E9D1 26A5 F0D4 9DF7 792B C2E2 B4BF 4530 D39B 2D51
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
