On Sun, 03 May 2026 at 00:00:34 +1000, Seth McDonald wrote:
> (1) The proxy store state (proxy_store_t) member 'is_fake' is seemingly
> supposed to be set to 1 in proxy_do_create_box() when dry-running.
Actually, may I ask what the purpose of 'is_fake' really is? It's
commented as indicating a dry run, but is only toggled on when calling
create_box() and toggled off when calling delete_box(). It's also not
consistently used, with proxy functions such as fetch_msg() and
store_msg() just using DFlags & DRYRUN instead, despite having access to
is_fake. Which gives the impression that is_fake is either intended to
indicate something other than "this is a dry/fake run", or its
implementation is incomplete.
Take care,
Seth McDonald.
--
E9D1 26A5 F0D4 9DF7 792B C2E2 B4BF 4530 D39B 2D51
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
