On Fri, Jun 19, 2026 at 05:23:27PM +1000, Seth McDonald wrote:
I have noticed the SASL-related error messages are too fine-grained to
be kept in drv_imap.c, but would be duplicated if moved to each
sasl_*.c. So I've added a sasl_common.c file to house small functions,
such as specific error messages, which can be called by either SASL
implementation.
that's entirely expected, which is one of the reasons i don't think the
abstraction is worth it.
to avoid having a ton of tiny files, just put everything into one
imap_auth.c, and keep the ifdefs in there (the alternative would imply
ifs in the build system, which isn't any better).
P.S. For a patch, would you prefer it be based on master or
master-next?
-next.
upon a quick scan, i don't see why this branch shouldn't become master
as-is. i'd have to re-check before i actually push, but i think i'm
merely trying to hold off the branching point between stable and
development.
(background: originally, i used cherry-picks, because coming from cvs
that was the only option. then i switched to forward-merges, which is
nice, but is actually quite a pain for releasing security fixes when the
merge is unclean. so i'm considering going back to cherry-picks, but i'm
not really happy about the prospect, because git still sucks at tracking
cherry-picks.)
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
