I applied the fix and uploaded it to CVS.
I did the same with the bug posted by Uwe Zimmerman.

about isParagraphE: it was introduced almost 2 years ago.
I remember I didn't exactly see the point of it, but I
didn't see what harm it could do.

SourceForge promised to have the CVS upgrades ready
by thursday. Maybe I'll release a new iText version
next week. If not, it will be after the International
Filmfestival Flanders Ghent.

br,
Bruno

Quoting Ken AtPdi <[EMAIL PROTECTED]>:

> How do I go about getting a suggested fix included into the code?
> 
> We had a problem where long paragraphs where positioned against the left 
> side of the page rather than being properly indented.  This situation 
> occured only when the paragraph started on one page, filled a second and 
> extended onto a third page.  It appeared that when no elements were added on
> 
> a page, the positioning was rendered incorrectly.
> 
> We tracked this down to a boolean flag in the PdfDocument class called 
> 'isParagraphE'.  it appears to have been inserted to help control indents, 
> but does not appear to work correctly in the situation described above.  The
> 
> line numbers referenced are those in the currently available source.
> 
> To remedy the problem we changed line 2130 from
> 
>     if(isParagraphE && isNewpage && newline) {
> 
> to
> 
>     if(isNewpage && newline) {
> 
> Since this is the only place the variable is referenced for its content, to
> 
> clean up the process the following lines could also be removed:
> 
>     505 (declaration)
>     1238 (set to true)
>     1325 (set to false)
> 
> We would appreciate any feedback regarding this change, positive or 
> negative.  If this 'fix' actually breaks something else, we would appreciate
> 
> the enlightenment and suggestions as to how to really fix the problem.
> 
> If this is not the forum to make this suggestion, please inform me so we can
> 
> do this right.
> 
> Thank you
> 
> Ken Beukelman
> Personnel Decisions International


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
iText-questions mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/itext-questions

Reply via email to